View Issue Details

IDProjectCategoryView StatusLast Update
0000150Industrial-Craft²tools / electric itemspublic2012-12-13 12:17
ReporterVictorJavAdoreAssigned ToRichardG 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinuxOSUbuntuOS Version12.10
Product Version 
Target VersionFixed in Version 
Summary0000150: OV/OD Scanner check the player's position metadata instead of the ores' metadata
DescriptionWhen scanning the area beneath the player, the ores are only counted only if the metadata (damage value) in valuableOres list is the same as the block the player is standing in, not metadata they actually have in the world.
For example, Iridium (id 703:2), if it's in the list of valuable ores, will only be counted if the block the player is standing in has a metadata/damage value of 2 as well.
Steps To ReproduceReproduction might be unnecessary since the problem is so clear in the source, but there it is :
Change the valuableOres list in IC2.cfg to "703-2:1000", in order to scan for Iridium Ore only.
Create a world with Iridium Ore below the player. The scan will output 0. then put some grass and a Fern with metadata/damage 2 (the pine-like one). Scan while standing in the fern. See a positive scan result.
Additional InformationVery easy to fix.
The problem is in ItemScanner class, is function "valueOfArea". When calculating "metaData" inside the loops, there's something like "worldObj.h(x,y,z)", where x, y and z are the player's coords. Change these x, y, z to blockX, blockY, blockZ like for "blockId" above, and it should be fine.
TagsNo tags attached.
Minecraft Version

Activities

RichardG

2012-12-13 12:17

administrator   ~0000427

Fixed

Issue History

Date Modified Username Field Change
2012-12-09 15:58 VictorJavAdore New Issue
2012-12-13 12:17 RichardG Note Added: 0000427
2012-12-13 12:17 RichardG Status new => resolved
2012-12-13 12:17 RichardG Fixed in Version => 1.109
2012-12-13 12:17 RichardG Resolution open => fixed
2012-12-13 12:17 RichardG Assigned To => RichardG