View Issue Details

IDProjectCategoryView StatusLast Update
0002410Industrial-Craft²crossmod-compatibility / submodules / APIpublic2019-04-09 00:32
ReporterAaron1011Assigned ToChocohead 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in VersionBuilds for MC 1.12.x 
Summary0002410: EntityMiningLaser fires BlockEvent.BreakEvent, but does not check if the event is cancelled
DescriptionEntityMiningLaser#hitBlock fires a BlockEvent.BreakEvent before attempting to break the block hit by the mining laser. However, the cancellation status of this event is never checked. If a mod cancels the event from its event listener, the block will break anyway.

To ensure compatibility with other mods, IC2 should check if the BlockEvent.BreakEvent that it fires is cancelled (as it does with the LaserEvent.LaserHitsBlockEvent fired before the BlockEvent.BreakEvent).
Steps To Reproduce1. Create a mod containing an event listener for BlockEvent.BreakEvent, or add such a listener to an existing mod. This listener should cancel
all events.
2. Fire an IC2 Mining Laser at a block
2. Observe that the block is broken by the mining laser, even though the event listener was called.
TagsNo tags attached.
Minecraft Version1.12.2

Activities

Chocohead

2019-04-09 00:32

developer   ~0005970

Fixed in IC2 2.8.107

Issue History

Date Modified Username Field Change
2018-08-17 23:58 Aaron1011 New Issue
2019-04-09 00:32 Chocohead Assigned To => Chocohead
2019-04-09 00:32 Chocohead Status new => resolved
2019-04-09 00:32 Chocohead Resolution open => fixed
2019-04-09 00:32 Chocohead Fixed in Version => Builds for MC 1.12.x
2019-04-09 00:32 Chocohead Note Added: 0005970