View Issue Details

IDProjectCategoryView StatusLast Update
0002538Industrial-Craft²crossmod-compatibility / submodules / APIpublic2019-05-05 18:07
ReporterescapeeAssigned ToPlayer 
PrioritylowSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in VersionBuilds for MC 1.12.x 
Summary0002538: Dimensions crash if they return a value of 0 from getHeight()
Descriptionhttps://github.com/TeamWizardry/Wizardry/issues/264
https://github.com/TeamWizardry/Wizardry/issues/39

It seems this has been reported to you here, and since we said we'd fix it on our end, it wasn't touched here.
https://bt.industrial-craft.net/view.php?id=2264#c5452

There is unfortunately nothing about WorldProvider#getHeight and WorldProvider#getAverageGroundLevel that specifies what ranges of values either could take, so it is on you to assure that the inputs your getting aren't invalid for your calculations. At the minimum, have a check for if either is zero or negative, and if so, replace it with a dummy value.

We are ok with changing the values on our end to prevent this crash, but unless you fix it on your end once, it will be a rare but reoccurring issue in other mods.
TagsNo tags attached.
Minecraft Version1.12.2

Relationships

duplicate of 0002264 resolvedChocohead [1.12.1] Crash on world load 

Activities

Chocohead

2019-05-05 18:07

developer   ~0006010

Fixed in IC2 2.8.128

Issue History

Date Modified Username Field Change
2019-05-05 17:19 escapee New Issue
2019-05-05 18:07 Chocohead Assigned To => Player
2019-05-05 18:07 Chocohead Status new => resolved
2019-05-05 18:07 Chocohead Resolution open => fixed
2019-05-05 18:07 Chocohead Fixed in Version => Builds for MC 1.12.x
2019-05-05 18:07 Chocohead Note Added: 0006010
2019-05-05 18:07 Chocohead Relationship added duplicate of 0002264