View Issue Details

IDProjectCategoryView StatusLast Update
0001869Industrial-Craft²general / otherpublic2017-07-25 05:41
Reporterbboldt Assigned ToPlayer  
PrioritynormalSeveritycrashReproducibilityhave not tried
Status closedResolutionfixed 
PlatformLinux 
Summary0001869: Crash - java.util.ConcurrentModificationException (industrialcraft-2-2.3.232-ex18)
DescriptionFrom what I can gather, people are causing the server to crash when they join somehow.

* Forge 1808
* IC2 232-ex18

http://pastebin.com/Kh6ieESw
Additional Informationhttps://github.com/BBoldt/ThePioneers/issues/64
TagsNo tags attached.
Minecraft Version

Relationships

has duplicate 0001938 closedAroma1997 When afk in title menu and try to get back on server after a while, MC quit to desktop. 
has duplicate 0001971 closedAroma1997 Crash when loading already existing worlds 
has duplicate 0001956 closedAroma1997 The client crashes after reconnecting to a server. 
has duplicate 0001968 closedAroma1997 Crash on logging into Server [java.util.ConcurrentModificationException] 
has duplicate 0002035 closedAroma1997 When holding a Rf tools builder quarry shape card and setting the size my client crashed to desktop. CME java.util.ArrayList$Itr 
has duplicate 0002038 closedAroma1997 Sometimes client crashed when join to server 
has duplicate 0002046 closedAroma1997 Crash on reconnect to server 

Activities

Cauli

2016-05-05 23:21

reporter   ~0004488

http://pastebin.com/rtCrMdjL

Same issue here. Players get a crash and then the log spams. Only a full restart of client and server works.

If the affected player doesn't restart their client the same issue will happen again.

bboldt

2016-05-06 07:16

reporter   ~0004489

Very similar crash, this time clientside:
https://gist.github.com/294a42e9e233d2a433432d390082d504

oitsjustjose

2016-07-04 14:42

reporter   ~0004609

Yup, I still have the same issue in not only 1.8.9 but 1.9.4 and 1.10.

Chocohead

2016-07-04 22:56

developer   ~0004610

Is there any match in mod lists (especially between versions)? It's definitely a cross mod interaction bug, but the crash reports so far have far too many mods to be able to draw conclusions.

slidingmike

2016-07-10 22:31

reporter   ~0004617

http://pastebin.com/1byrHn8Y

slidingmike

2016-07-10 22:49

reporter   ~0004618

I can't compare version to version since Spilled Juice is on 1.10.2, but there are similarities. Over 55 in fact. I'm thinking it might be a Neotech issue as we've had an increase number of other issues including NPEs and crashes related to Neotech.

A2020

2016-08-16 12:16

reporter   ~0004706

2 Mods that I found repited on the crashes are Trashslot and Chameleon Library.

But a crash that was marked as duplicate (0001971) where it happens kinda the same in my dev environment I have way less mods and none of those are there.

http://pastebin.com/3ntpVTXk

Aroma1997

2016-08-16 18:37

developer   ~0004707

Do you consistently get this crash?

Dijkstra

2016-08-24 12:12

reporter   ~0004715

It is not, every time you join server but it is consistent

Dijkstra

2016-09-14 08:44

reporter   ~0004761

IC2 Team I believe I know how this can be fixed, I be sure if you would not mind showing me the loop, that is going through the Array List, but if right I am right what is comes down is some where a long the line in the loop you remove one items in the list has been removed and if that is the case I can help you.

Chocohead

2016-10-01 21:41

developer   ~0004781

The loop is vanilla code (and doesn't modify the list at all), whilst the nearest line of our code in the stacktrace is a constructor call. Something must be changing the recipe list as it's being looped over, but it's very hard to work out what.

Aroma1997

2016-10-02 11:33

developer   ~0004783

Yes. The loop itself is in vanilla code, so either something modifies it, while vanilla iterates over it through a method inside of the loop, or from another thread. I suspect, it's another Thread, which would also explain the inconsitency of this. If you're interested in the loop, it's in CraftingManager.findMatchingRecipe(InventoryCrafting craftMatrix, World worldIn)

hypsellis

2016-10-14 21:48

reporter   ~0004804

I get the same crash too when I try to load a world http://pastebin.com/pszjxFh4

Aroma1997

2016-11-02 21:18

developer   ~0004836

Ok, so except for 0001971, CraftTweaker is always present.
Crafttweaker sync their recipe changes after you join a multiplayer server and modify the recipe list. I assume, they do this off-thread, so it may cause a ConcurrentModificationException.
I'll see, what I can do.

everseeking

2016-11-08 00:24

reporter   ~0004846

Another related crash log from Infinity Lite 1.10.2, using industrialcraft-2-2.6.87-ex110.jar

http://pastebin.com/di46SEYu

Chocohead

2016-11-17 16:11

developer   ~0004852

All the signs still point to CraftTweaker.

Aroma1997

2016-11-17 17:19

developer   ~0004853

Last edited: 2016-11-17 17:58

Ok, could anyone of you, who can actually reproduce the issue add this mod to the mods folder and then give me the new crash log, that ideally appears: http://files.aroma1997.org/tmp/TestModThingymabobdoohicky-1.9.4-4.jar ?

hypsellis

2016-11-19 12:05

reporter   ~0004860

I ask me if this issue isn't linked to this one https://github.com/Zkaface/TAIGA/issues/56

Aroma1997

2016-11-19 14:16

developer   ~0004862

I don't think, it is.

Chocohead

2016-11-19 14:23

developer   ~0004870

It could only be a factor if the world ID map isn't saved properly when it crashes, but IC2 itself isn't causing that because it's crashing with the recipe list not world gen.

HunterzCZ

2016-11-21 18:06

reporter   ~0004879

When TestMod installed:

http://pastebin.com/ezbQqucc

Chocohead

2016-11-22 17:17

developer   ~0004880

Try using it with IC2 2.6.112

Aroma1997

2016-11-22 18:31

developer   ~0004885

could you send the fml-client-latest.log file as well?

HunterzCZ

2016-11-23 06:14

reporter  

fml-client-latest.log (1,553,776 bytes)

HunterzCZ

2016-11-23 06:15

reporter   ~0004886

log added

hypsellis

2016-11-23 11:41

reporter   ~0004887

Okay this issue wasn't linked with the other one I linked in my old post. Anyway I still get this issue randomly, and I haven't any ideas of what causes it.

Aroma1997

2016-11-24 21:48

developer   ~0004889

So you're still getting the concurrentmodificationexception with the same stacktrace as before, even though you got the testmod installed?

HunterzCZ

2016-11-25 07:38

reporter   ~0004890

with testmod is stackrace different, but still points to IC2 imho

hypsellis

2016-11-25 08:16

reporter   ~0004891

Oh my bad I hadn't updated to the last ic2 version. I didn't get the crash for the time with this version, but I get it rarely, so I can't be sure. And no I didn't try with testmod, I suppose I should.

Aroma1997

2016-11-25 10:22

developer   ~0004892

Cound you post the crash log and the log file you get with the testmod. Replacing the stacktrace of the crash is the entire point of that testmod.

Backslash

2016-11-30 11:49

reporter   ~0004899

Crashlog: http://pastebin.com/uShPEEMv
latest: https://gist.github.com/UnPure/c2ba3758f3ced9a66214d649d798864f

Log files are created while using the testmod.

Backslash

2016-12-01 09:24

reporter   ~0004901

And the next one:
Crashlog: http://pastebin.com/83iuLj7e
latest: https://gist.github.com/UnPure/0de8c6c46f7fdb5373d4b4c0665da0c5

Again, both files are created while using the testmod.

Aroma1997

2016-12-02 18:26

developer   ~0004903

Try again using this: http://files.aroma1997.org/tmp/TestModThingymabobdoohicky-1.9.4-5.jar

Dijkstra

2016-12-18 08:59

reporter   ~0004952

here a crash report using the test mod thingy
https://gist.github.com/Dijkstra1/25ffd28048d1f7c256a970e596efe0fb

Aroma1997

2016-12-18 16:10

developer   ~0004953

Could you send me the full log file?

Dijkstra

2016-12-18 21:15

reporter   ~0004954

this looks likes it is the log that goes that crash report
https://gist.github.com/Dijkstra1/1845b357d8c3405c0e9df66e0e193edc

Aroma1997

2016-12-18 21:18

developer   ~0004955

Last edited: 2016-12-18 21:30

That is not the full log. Some of the important parts are missing. (I need the fml-client-latest.log file, when it happens again)

Terpo

2016-12-21 18:18

reporter   ~0004956

There we go, took a while to get a new crash.
TestModThingy is only installed on client, my server dont have it.

Crashlog:
http://terpo.org/blog/upload/mc/ic2crashes/crash-2016-12-21_19.09.27-client.txt
http://terpo.org/blog/upload/mc/ic2crashes/latest-client-2016-12-21_19.09.27.log

Current modlist:
http://blog.terpo.org/upload/mc/modlist.txt
Forge: 12.18.3.2185
IC2: industrialcraft-2-2.6.129-ex110

Gaelan

2016-12-28 23:37

reporter   ~0004989

Last edited: 2016-12-28 23:38

CraftTweaker is not guilty, I'm having this issue in a pack without it (or any other recipe-tweaking mod). Here's a log with TestModThingy(TM): https://gist.github.com/e01e5d6f3abfef5ed06f1b79a5353c9f

EDIT: Huh, the random crash message is quite fitting. "Oh - I know what I did wrong!"

Here is a list of mods included in both my and Terpo's packs, with digits stripped so versions didn't break the comparison:
AutoRegLib-.-.jar
Baubles-..-...jar
BloodMagic-..-..-.jar
Chameleon-.-...jar
Chisel-MC..-....jar
CodeChickenCore-..-...-universal.jar
CodeChickenLib-..-...-universal.jar
CookingForBlockheads_..-...jar
ElecCore-..-...jar
EnderCore-..-...-beta.jar
EnderIO-..-..._beta.jar
Guide-API-..-..-.jar
ImmersiveEngineering-.-.jar
JustEnoughResources-..-....jar
Mantle-..-...jar
Pam's HarvestCraft ..-..h.jar
Psi-r.-.jar
Quark-r.-.jar
Railcraft_..-...jar
StorageDrawers-..-...jar
SuperCircuitMaker-...jar
TConstruct-..-...jar
TestModThingymabobdoohicky-..-.jar
TinkerToolLeveling-..-...jar
chiselsandbits-..jar
compatlayer-.-...jar
deepresonance-.x-...jar
forestry_..-....jar
industrialcraft--..-ex.jar
jei_..-....jar
mcjtylib-.x-...jar
rftools-.x-..jar
rftoolsctrl-.x-...jar
rftoolsdim-.x-..jar
I also had MCMultipart, but it was auto-downloaded into a subfolder so it didn't get on the list. I also had EJML in a subfolder, not sure if Terpo somehow managed to install IC2 without it or just missed it in his list.

This is interesting–iChunUtil is guilty here, but it isn't on Terpo's modlist. Seems like editing this list may be something like null itemstacks pre-1.11 where it may not be "correct" but it is common enough that mods need to expect/handle it.

Aroma1997

2016-12-29 16:54

developer   ~0004990

This problem is caused by multiple mods. CraftTweaker was one of them (that's most likely fixed by now). iChun Util is another one of them. iChun said, he'll fix it in January.
There are probably more of them...

Chocohead

2016-12-29 17:38

developer   ~0004991

It's a very easy thing to accidentally do, and because the chance of it crashing is somewhat low it doesn't get noticed.

whatthedrunk

2017-05-26 01:16

reporter   ~0005265

Another mod that causes this issue is NoMoreRecipeConflicts.

Player

2017-05-29 03:20

administrator   ~0005275

The latest builds for 1.10 and 1.11 should have a workaround for this problem.

The actual bug is in the mods modifying the recipe list. Since the recipe list is a global singleton for client and server, modifying it would require proper synchronization - which doesn't exist. So basically no mod may change it as soon as the client is live.

Issue History

Date Modified Username Field Change
2016-05-05 19:23 bboldt New Issue
2016-05-05 23:21 Cauli Note Added: 0004488
2016-05-06 07:16 bboldt Note Added: 0004489
2016-07-04 14:42 oitsjustjose Note Added: 0004609
2016-07-04 22:56 Chocohead Note Added: 0004610
2016-07-05 10:42 Chocohead Status new => feedback
2016-07-10 22:31 slidingmike Note Added: 0004617
2016-07-10 22:49 slidingmike Note Added: 0004618
2016-07-27 17:32 Chocohead Relationship added has duplicate 0001938
2016-08-15 20:03 Chocohead Relationship added has duplicate 0001971
2016-08-16 12:16 A2020 Note Added: 0004706
2016-08-16 18:37 Aroma1997 Note Added: 0004707
2016-08-16 22:15 Chocohead Relationship added has duplicate 0001956
2016-08-16 22:15 Chocohead Relationship added has duplicate 0001968
2016-08-24 12:12 Dijkstra Note Added: 0004715
2016-09-14 08:44 Dijkstra Note Added: 0004761
2016-10-01 21:41 Chocohead Note Added: 0004781
2016-10-02 11:33 Aroma1997 Note Added: 0004783
2016-10-14 21:48 hypsellis Note Added: 0004804
2016-11-02 21:18 Aroma1997 Note Added: 0004836
2016-11-08 00:24 everseeking Note Added: 0004846
2016-11-14 18:48 Chocohead Relationship added has duplicate 0002035
2016-11-17 16:08 Chocohead Relationship added has duplicate 0002038
2016-11-17 16:11 Chocohead Note Added: 0004852
2016-11-17 17:19 Aroma1997 Note Added: 0004853
2016-11-17 17:58 Aroma1997 Note Edited: 0004853
2016-11-19 12:05 hypsellis Note Added: 0004860
2016-11-19 14:16 Aroma1997 Note Added: 0004862
2016-11-19 14:23 Chocohead Note Added: 0004870
2016-11-21 18:06 HunterzCZ Note Added: 0004879
2016-11-22 17:17 Chocohead Note Added: 0004880
2016-11-22 18:31 Aroma1997 Note Added: 0004885
2016-11-23 06:15 HunterzCZ File Added: fml-client-latest.log
2016-11-23 06:15 HunterzCZ Note Added: 0004886
2016-11-23 11:41 hypsellis Note Added: 0004887
2016-11-24 21:48 Aroma1997 Note Added: 0004889
2016-11-25 07:38 HunterzCZ Note Added: 0004890
2016-11-25 08:16 hypsellis Note Added: 0004891
2016-11-25 10:22 Aroma1997 Note Added: 0004892
2016-11-29 15:00 Chocohead Relationship added has duplicate 0002046
2016-11-30 11:49 Backslash Note Added: 0004899
2016-12-01 09:24 Backslash Note Added: 0004901
2016-12-02 18:26 Aroma1997 Note Added: 0004903
2016-12-18 08:59 Dijkstra Note Added: 0004952
2016-12-18 16:10 Aroma1997 Note Added: 0004953
2016-12-18 21:15 Dijkstra Note Added: 0004954
2016-12-18 21:18 Aroma1997 Note Added: 0004955
2016-12-18 21:30 Aroma1997 Note Edited: 0004955
2016-12-21 18:18 Terpo Note Added: 0004956
2016-12-28 23:37 Gaelan Note Added: 0004989
2016-12-28 23:38 Gaelan Note Edited: 0004989
2016-12-29 16:54 Aroma1997 Note Added: 0004990
2016-12-29 17:38 Chocohead Note Added: 0004991
2017-05-26 01:16 whatthedrunk Note Added: 0005265
2017-05-29 03:20 Player Note Added: 0005275
2017-07-25 05:41 Player Assigned To => Player
2017-07-25 05:41 Player Status feedback => closed
2017-07-25 05:41 Player Resolution open => fixed