View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000344Industrial-Craft²crossmod-compatibility / submodules / APIpublic2013-03-20 23:142013-10-07 08:20
Reporterjakimfett Assigned ToThunderdark  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
PlatformLinuxOSUbuntu ServerOS Version12.10
Summary0000344: Block breaking permissions
DescriptionI am using MCPC+ with WorldGuard and Factions for area protection. However, IC2 items that break blocks (such as the mining laser, nuke, and iTNT) can bypass area protection.
Steps To ReproduceCreate an MCPC+ server with Worldguard, Towny, or Factions. Create a protected area with one of the three protection plugins. Use a mining laser inside the area.
Additional InformationI've spoken with Bukkit people, MCPC+ people, and IC2 people, and everybody says it's the other guy. Bukkit people say IC2 isn't passing block break events. MCPC+ people say it's an issue with Bukkit. IC2 people say it's either a Bukkit issue or something with MCPC+.
TagsNo tags attached.
Minecraft Version

Activities

jakimfett

2013-03-20 23:25

reporter   ~0000863

Last edited: 2013-03-20 23:32

 There is a build of IC2 with the correct events here: http://www.mcportcentral.co.za/index.php?topic=4657.msg25174#msg25174

I've also reported the issue here: http://youtrack.sk89q.com/issue/WORLDGUARD-2641

Build created by Bloodshot. Any chance of merging the changes into the main IC2 builds?

Wliu

2013-03-21 21:10

reporter   ~0000864

Last edited: 2013-03-21 21:11

 Also, PLEASE do not report stuff that is broken with Bukkit/MCPC+/etc. on the IC2 bugtracker.
However, I think that IC2 does do some weird things, like a separate explosion class.

jakimfett

2013-03-22 17:08

reporter   ~0000865

As far as I could determine, this isn't an issue with "Bukkit/MCPC+/etc", as the issue is resolved when blockbreak events are added (see previous comment with link to the build by Bloodshot).

Honestly, I'm tired of everyone saying it's someone else's fault. Maybe MCPC+ needs to do a better job of "interpreting" IC2 events into Bukkit events. Maybe Bukkit is doing it wrong. What I know is that the only solution that has been successful requires the addition of events to the IC2 code. To me, that says it's an issue with IC2, not with something else.

Wliu

2013-03-22 21:18

reporter   ~0000866

http://forum.industrial-craft.net/index.php?page=Thread&postID=105045#post105045

jakimfett

2013-03-23 05:17

reporter   ~0000867

Last edited: 2013-03-23 05:18

 @Wliu: I saw that post, but it fails to address the fact that by adding events to the plugin (see Bloodshot's recompiled version), the laser now works properly.

As a MCPC+ developer who has added events to multiple plugins and mods, if simply changing something in MCPC+ was an option, I would imagine that Bloodshot would have done it, rather than modifying 3 different plugins and 3 different mods (http://www.mcportcentral.co.za/index.php?topic=4657.msg25172#msg25172). If it's just a hack to work around an MCPC+ issue, then why do it the hard way, instead of fixing the problem at the source? I could be wrong, but nothing I've seen so far would indicate otherwise.

I could be wrong. But like I've said above, I'm tired of everybody blaming someone else without any proof (that I've been shown, at least). So far, logic dictates that there is an established event system, and IC2 (and a ton of other FML mods) are failing to follow.

Wliu

2013-03-23 14:36

reporter   ~0000868

Then it's up to the IC2 folks~ :)

immibis

2013-06-03 13:36

reporter   ~0001029

Everyone blames everyone else because it's everyone's problem.

The reason lasers do not fire block break events is that there's no code to fire block break events.

IC2 is a Forge mod. Forge does not have block break events, and Forge is not Bukkit. As helpful as it would be, IC2 is under no obligation to fire Bukkit block break events.

Obviously from MCPC's side, it would be easier for the MCPC developers if all mods would fire block break events, so the MCPC people blame mods.
From the mod's side, it would be easier for the mod developers if MCPC would magically guess when to fire them, or if there would be a special version (made by someone on the MCPC side) which would fire them, so the mod people blame MCPC.

jakimfett

2013-06-05 01:12

reporter   ~0001035

If a forge mod provides block break events, will it mess things up on the forge side? For example, if the IC2 developers decided that they would commit to adding block break events for everything the mod does, would it make it incompatible with Forge?

Conversely, if a mod does provide block break events, can MCPC/Bukkit catch them? Or does something *else* have to be done?

immibis

2013-06-08 05:53

reporter   ~0001040

It would not make it incompatible with Forge - but there would still be a special relationship between IC2 and MCPC, either on IC2's side (if IC2 fires Bukkit block break events) or MCPC's (if IC2 fires its own block break events and IC2 catches them).

The better situation would be if IC2 fired Bukkit block break events - otherwise every mod would have to add its own block break events and MCPC would have to catch all of them.

blood said he's working on an MCPC API other mods can use to work properly with Bukkit plugins.

Thunderdark

2013-10-07 08:20

viewer   ~0001710

clean up Manits Bug Tracker..close automatic all Bug report > 3 months if the error still exists in the current version > IC2 2.0.248 please report new Thx.

Issue History

Date Modified Username Field Change
2013-03-20 23:14 jakimfett New Issue
2013-03-20 23:25 jakimfett Note Added: 0000863
2013-03-20 23:32 jakimfett Note Edited: 0000863
2013-03-21 21:10 Wliu Note Added: 0000864
2013-03-21 21:11 Wliu Note Edited: 0000864
2013-03-22 17:08 jakimfett Note Added: 0000865
2013-03-22 21:18 Wliu Note Added: 0000866
2013-03-23 05:17 jakimfett Note Added: 0000867
2013-03-23 05:18 jakimfett Note Edited: 0000867
2013-03-23 14:36 Wliu Note Added: 0000868
2013-06-03 13:36 immibis Note Added: 0001029
2013-06-05 01:12 jakimfett Note Added: 0001035
2013-06-08 05:53 immibis Note Added: 0001040
2013-10-07 08:20 Thunderdark Note Added: 0001710
2013-10-07 08:20 Thunderdark Status new => closed
2013-10-07 08:20 Thunderdark Assigned To => Thunderdark
2013-10-07 08:20 Thunderdark Resolution open => no change required