View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001701 | Industrial-Craft² | crossmod-compatibility / submodules / API | public | 2015-08-15 04:47 | 2015-08-19 08:03 |
| Reporter | Max | Assigned To | Aroma1997 | ||
| Priority | low | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | suspended | ||
| Summary | 0001701: "Harvest" misspelt in API | ||||
| Description | In the API the word "harvest" is thrice misspelt as "havest". - ic2.api.crops.CropCard.getOptimalHavestSize() method name - javadoc for that method says "Crop Havester" - javadoc for ic2.api.crops.ICropTile.harvest_automated(...) mentions the misspelt "getOptimalHavestSize". industrialcraft-2-2.2.763-experimental-api.jar | ||||
| Steps To Reproduce | n/a | ||||
| Additional Information | No doubt related to 0001367. | ||||
| Tags | No tags attached. | ||||
| Minecraft Version | |||||
|
|
Alternatively here are line numbers: ic2/ api/ CropCard.java -> 244: ... in Crop Havester with ... -> 250: ... getOptimalHavestSize(ICropTile crop); ICropTile.java -> 238: ... check getOptimalHavestSize() for ... |
|
|
German devs make English spelling mistakes ;) |
|
|
Since this change would change the API without backwardscompatibility, we can't do it now. (Atleast not in a proper way). I added it to the API-breaking-todo-list. |
|
|
Sorry to reopen a closed issue, but what about this for the interim: /* Use getOptimalHarvestSize */ @Depricated int getOptimalHavestSize(...){ getOptimalHarvestSize(...); } /* javadoc description */ abstract int getOptimalHarvestSize(...) {} |
|
|
That would crash addons that are not up do date. There IS a way to do it, but that involves having the misspelled one as deprecated and the normal one by default returning what the misspelled one does. The cleaner way to do this is to remove the misspelled one and add the normal one. But as I said, this would crash. |
|
|
Doh; agreed. You can re-close this issue now. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-08-15 04:47 | Max | New Issue | |
| 2015-08-15 04:51 | Max | Note Added: 0004113 | |
| 2015-08-15 23:51 | Chocohead | Note Added: 0004115 | |
| 2015-08-17 19:49 | Aroma1997 | Note Added: 0004116 | |
| 2015-08-17 19:50 | Aroma1997 | Status | new => closed |
| 2015-08-17 19:50 | Aroma1997 | Assigned To | => Aroma1997 |
| 2015-08-17 19:50 | Aroma1997 | Resolution | open => suspended |
| 2015-08-18 18:49 | Max | Note Added: 0004117 | |
| 2015-08-18 18:49 | Max | Status | closed => feedback |
| 2015-08-18 18:49 | Max | Resolution | suspended => reopened |
| 2015-08-18 20:52 | Aroma1997 | Note Added: 0004118 | |
| 2015-08-18 23:01 | Max | Note Added: 0004119 | |
| 2015-08-18 23:01 | Max | Status | feedback => assigned |
| 2015-08-19 08:03 | Aroma1997 | Status | assigned => closed |
| 2015-08-19 08:03 | Aroma1997 | Resolution | reopened => suspended |
