View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002455||Industrial-Craft²||general / other||public||2018-12-17 18:14||2020-06-15 05:37|
|Target Version||Fixed in Version|
|Summary||0002455: Rubber boots ignored for fall heights 13 or greater|
|Description||When falling from a cliff of at least 13 blocks, the player takes full damage and the boots take no damage. This means that the height table at https://wiki.industrial-craft.net/index.php?title=Rubber_Boots#Technical_Details does not apply, and the advice about using rubber boots to make using an electric jetpack safer is less applicable. Fall distances of 5 to 12 cause zero damage to the player, and 1 to 4 damage to the boots.|
|Steps To Reproduce||1. Find (or make) a cliff at least 13 blocks high.|
2. Put on some rubber boots.
3. Walk off the cliff.
4. Observe the damage to the player and to the boots.
|Additional Information||At first, I thought this might have been introduced by the fix to 0002236, but the rubber boots work as expected in 2.6.259 (for 1.10.2, with a fix for that bug), and are broken in 2.8.12 (before that bug was fixed, running in 1.12.2)|
|Tags||No tags attached.|
||This is possibly from armour calculations in vanilla changing, should be possible to get the old fall mechanics back again though.|
||I have been unsuccessful at finding when these changes to armour calculations in vanilla happened. Could you please provide a link to what you're referring to?|
||The changes vanilla made in 1.9 are staggered over to only apply to Forge mods in 1.11, thus I suspect it's something subtle in how Forge changed armour protection to take into account toughness which has broken the rubber boot's absorption that otherwise hasn't changed. The PR to Forge is here for reference: https://github.com/MinecraftForge/MinecraftForge/pull/3838|
I couldn't make sense of why that PR would cause this, but I finally did some experimenting with different 1.11 forge versions, and the changeover starts with Forge 188.8.131.524, so I think this is the relevant PR: https://github.com/MinecraftForge/MinecraftForge/pull/4106
It looks like handling the fall damage reduction via ISpecialArmor.getProperties will no longer work (since DamageSource treats fall damage as unblockable), but the onEntityLivingFallEvent still does, which is why short falls (up to 12 blocks) still cause zero player damage when wearing rubber boots.
|2018-12-17 18:14||MauveCloud||New Issue|
|2018-12-20 21:58||Chocohead||Status||new => confirmed|
|2018-12-20 21:58||Chocohead||Note Added: 0005851|
|2019-04-08 22:22||MauveCloud||Note Added: 0005966|
|2019-04-08 23:21||Chocohead||Note Added: 0005967|
|2020-06-15 05:37||MauveCloud||Note Added: 0006264|